Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add categories to tests #1301

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Add categories to tests #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
496cdfc
Do not run flaky test class on github
tdrwenski Feb 2, 2024
50c09e5
Do not run tests using external server on github
tdrwenski Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dap4/src/test/java/dap4/test/TestHyrax.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.slf4j.Logger;
Expand All @@ -19,6 +20,7 @@
import java.nio.file.NoSuchFileException;
import java.util.ArrayList;
import java.util.List;
import ucar.unidata.util.test.category.NeedsExternalResource;

/**
* This Test uses the JUNIT Version 4 parameterized test mechanism.
Expand All @@ -32,6 +34,7 @@
* from the test.opendap.org test server
*/

@Category(NeedsExternalResource.class)
@RunWith(Parameterized.class)
public class TestHyrax extends DapTestCommon implements Dap4ManifestIF {

Expand Down
3 changes: 3 additions & 0 deletions httpservices/src/test/java/ucar/httpservices/TestThreading.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@

import org.junit.Assert;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import ucar.httpservices.HTTPException;
Expand All @@ -45,10 +46,12 @@
import ucar.unidata.util.test.TestDir;
import ucar.unidata.util.test.UnitTestCommon;
import java.lang.invoke.MethodHandles;
import ucar.unidata.util.test.category.NotPullRequest;

/**
* Test interaction of multi-threading with httpservices.
*/
@Category(NotPullRequest.class)
public class TestThreading extends UnitTestCommon {
private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());

Expand Down
Loading