Fix remove deleted files from cache #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be applied to the RandomAccessFile cache but not NetcdfFile cache
tdrwenski
force-pushed
the
fix-deleted-file-cleanup
branch
from
985e290
to
527dcfa
Compare
haileyajohnson
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a possible problem with the fix from #1268. The goal there was to cleanup deleted files from the cache, since some users had issues deleting files that were locked by the RandomAccessFile cache. However, that change affected both that and the NetcdfFile cache, where a
locationcan be a file path or a url path (say for an aggregation). Since the url path doesn't point to an existing file it will always remove that from the cache. Here I propose fixing this by having a flag that can be turned on for the RandomAccessFile cache but off for other caches. Update to TDS in Unidata/tds#463.