Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty zip itemName in NetcdfFiles.makeUncompressed #1309

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Handle empty zip itemName in NetcdfFiles.makeUncompressed #1309

merged 1 commit into from
Mar 1, 2024

Conversation

rschmunk
Copy link
Contributor

@rschmunk rschmunk commented Mar 1, 2024 •
edited
Loading

Description of Changes

Trap for case of no (empty) itemName appended to file path when a zip is passed to NetcdfFiles to uncompress and open. See #1307.

PR Checklist

  • Link to any issues that the PR addresses
  • Add labels
  • Open as a draft PR
    until ready for review
  • Make sure GitHub tests pass
  • Mark PR as "Ready for Review"

haileyajohnson
haileyajohnson approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@haileyajohnson haileyajohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rschmunk !!!

@haileyajohnson haileyajohnson merged commit 3ee6068 into Unidata:maint-5.x Mar 1, 2024
10 checks passed
@rschmunk rschmunk mentioned this pull request Mar 13, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyajohnson haileyajohnson haileyajohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rschmunk @haileyajohnson