Fix grib collection NaNs bug #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l times after from being read due to axis being marked regular
haileyajohnson
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue that a variable missing from one grib partition would result in all values of the variable after that time returning NaN for the "best" dataset. This was due to the runtime axis being marked regular if the number of missing values is less than 5%. With a regular runtime axis, the variable is assumed to have values for all runtimes which messes up the lookup for which partition contains which runtime.
The proposed fix is to not allow a tolerance of 5% in the case of the grib coverage runtime axis. The runtime axis with missing values will then be marked irregular instead of regular, so it will keep track of which exact values it has.
Related to previous issue: #1063
Integration test added to the TDS for this fix: Unidata/tds#473
Jenkins tests passing on this branch: https://jenkins-aws.unidata.ucar.edu/job/tara-netcdf-java/51/