Test cleanup #1328
Merged
Test cleanup #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The only tests using the
TestSources.TestSetsisTestDConnect2. It was using the enumsTestSetEnum.Standard1, TestSetEnum.Constrained1, TestSetEnum.Remote2out of which onlyTestSetEnum.Standard1was actually run since the other two were not actually added toTestSets. Here I am removingRemote2all together since it refers to a thredds fmrc dataset not present on remotetest/gretty. TheConstrained1tests are not currently working due to diffs in the output, so I will just comment those out for now in theTestDConnect2so it is more explicit what is being run.In addition: