Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite groovy tests as junit #1334

Merged
merged 8 commits into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ Once you are satisfied with your work, there is one last step to complete before

### <a name="#gh-style-guidelines"></a>Follow these Style Guidelines

#### Java, Groovy, and Gradle
We are using the [Google Java Style Guide](https://google.github.io/styleguide/javaguide.html) for Java, Groovy, and Gradle, with these exceptions and augmentations:
#### Java and Gradle
We are using the [Google Java Style Guide](https://google.github.io/styleguide/javaguide.html) for Java and Gradle, with these exceptions and augmentations:

1. The recommended line width is 120, not 100.
Modern screens are much wider than tall, so having wider lines allows more code to fit on a screen.
Expand Down
4 changes: 0 additions & 4 deletions cdm/core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ apply from: "$rootDir/gradle/any/dependencies.gradle"
apply from: "$rootDir/gradle/any/java-library.gradle"
apply from: "$rootDir/gradle/any/protobuf.gradle"

apply plugin: 'groovy' // For Spock tests.

dependencies {
api enforcedPlatform(project(':netcdf-java-platform'))
implementation 'commons-math:commons-math'
Expand All @@ -32,9 +30,7 @@ dependencies {
testImplementation 'com.google.truth:truth'
testImplementation 'commons-io:commons-io'
testImplementation 'junit:junit'
testImplementation 'org.codehaus.groovy:groovy-all' // for Spock.
testImplementation 'org.mockito:mockito-core'
testImplementation 'org.spockframework:spock-core'

testRuntimeOnly 'ch.qos.logback:logback-classic'
}
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading