Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and extend Geotiff IFD handling to allow all integer types #1341

Merged
merged 4 commits into from
May 7, 2024
Merged

Fix and extend Geotiff IFD handling to allow all integer types #1341

merged 4 commits into from
May 7, 2024

Commits on May 6, 2024

  1. Fix and extend Geotiff IFD handling to allow all integer types 

    * Follows specs from pg. 15-16 of v6.0 TIFF:
  https://www.itu.int/itudoc/itu-t/com16/tiff-fx/docs/tiff6.pdf
* Added roundtrip tests of the private Geotiff method via reflection
* This does reveal an existing API flaw that will cause
  overflow of large unsigned integers
    @WeatherGod
    WeatherGod committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bbdf615 View commit details
    Browse the repository at this point in the history

  2. style check and some other cleanups

    @WeatherGod
    WeatherGod committed May 6, 2024
    Configuration menu
    Copy the full SHA
    07e9ec3 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Tara Drwenski <[email protected]>
    @WeatherGod @tdrwenski
    WeatherGod and tdrwenski committed May 7, 2024
    Configuration menu
    Copy the full SHA
    610b1fb View commit details
    Browse the repository at this point in the history

  2. Change some of the GeoTiff methods to package-private static 

    * This allows us to drop reflection in the TestIFDEntry tests
* Simplifies the test setup and execution
    @WeatherGod
    WeatherGod committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ec4f996 View commit details
    Browse the repository at this point in the history