NetcdfFiles should use its own logger #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haileyajohnson
approved these changes
May 23, 2024
|
I will ignore that failing test while I investigate it-- I just saw it on my PR yesterday as well, I'm sure it's not related to your changes |
Trying to figure out why I was not getting log messages from NetcdfFiles and found it was using a different class's logger.
|
I wasn't paying a lot of attention, @tdrwenski, but it looked like Github was simply timing out while running tests? Anyhow, thanks @haileyajohnson for commiting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to figure out why I was not getting log messages from NetcdfFiles and found it was using a different class's logger.
PR Checklist
until ready for review