Optimize Shuffle.decode method #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
haileyajohnson
force-pushed
the
shuffle_optimize
branch
from
421eae0
to
eaf242e
Compare
haileyajohnson
approved these changes
May 23, 2024
haileyajohnson
force-pushed
the
shuffle_optimize
branch
from
eaf242e
to
6ee9a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
While doing a profiling session I've noticed this method popping up over and over. Noticed there were some simple and obvious optimizations, like not allocating an extra array, and avoiding repeated multiplications in index computation, and thought to share the results with the wider community.
PR Checklist
until ready for review