Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Hurricane #124

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Hurricane #124

wants to merge 9 commits into from

Conversation

AodhanSweeney
Copy link
Contributor

No description provided.

@AodhanSweeney AodhanSweeney mentioned this pull request Jun 28, 2019
Closed
zbruick
zbruick suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@zbruick zbruick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - mainly minor cleanups to docstrings and error messages.

examples/HurricaneTracker.py Outdated Show resolved Hide resolved
examples/HurricaneTracker.py Outdated Show resolved Hide resolved
examples/HurricaneTracker.py Outdated Show resolved Hide resolved
examples/SPCTracker.py Outdated Show resolved Hide resolved
examples/SPCTracker.py Show resolved Hide resolved
examples/SPCTracker.py Outdated Show resolved Hide resolved
@zbruick
Copy link
Contributor

zbruick commented Jul 31, 2019

Some of these commits can still be squashed down it looks like

kgoebber and others added 8 commits July 31, 2019 15:15
@kgoebber
Add DIFAX example
7fe192a
Adding 2019 version of the HurricaneTracker Notebook.
36782cc
Changed whitelines, import orders, and got rid off the matplotlib inl…
910b25c 
…ine.
Another change to white spaces and imports.
f1b31fb
Again, changing syntax and imports.
369454b 
More changes to the spacing and syntax.

Changing syntax.

Another new syntax change to please Travis.

Adding one blank line.

Changing a dictionary call.
adding final changes to modulo formatting.
1103ffe 
Deleting images.json and BM.jpeg images because it was not conducive to actual example, now Hurricanes are plotted on a basic Cartopy image

Deleting Blue Marble feature of HurricaneTracker.py
Creating a new HurricaneTracker.py that works off the new National Hu…
64a8395 
…rricane Center data in siphon

Fixing a dummy call to siphon

Added a new play button widget and changed docstrings to match Pep8

Hurricane Tracker, using nhc from siphon.simplewebservice
Adding spc Tracker and the hurricane tracker with small updates.
32ffc25
@AodhanSweeney
Copy link
Contributor Author

Addresses issue #3 and tangent to issue #4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zbruick zbruick zbruick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AodhanSweeney @zbruick @kgoebber