Support reading GOES ABI and GLM from AWS #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeplycloudy
requested review from
dopplershift,
jrleeman and
lesserwhirls
as code owners
|
|
|
In cleaning up docs, adding tests, and a few other minor things, is it ok if I just push to your branch from here? |
|
Yes, go ahead!
… On Apr 11, 2018, at 15:58, Ryan May ***@***.***> wrote:
In cleaning up docs, adding tests, and a few other minor things, is it ok if I just push to your branch from here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
djhoese
reviewed
Nov 20, 2018
| """ Download the data and open (in memory) with netCDF """ | ||
| with NamedTemporaryFile(suffix='.nc') as temp: | ||
| # Create a temporary netCDF file to work around bug in netCDF C 4.4.1.1 | ||
| # We shouldn't actually need any file on disk. |
There was a problem hiding this comment.
Is there an existing bug report for this? Is this fixed now?
There was a problem hiding this comment.
I think this is fixed now.
|
One of my students using this script just ran into an issue where ABI data from 2019/244 (now in mode 6) only downloaded the first hour, even though the start, end datetimes spanned a whole day. Worth some further testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes and helper functions support reading GOES-16 data from the official NOAA AWS bucket. Based on an older version originally shared with me by @dopplershift.
Beware: no tests.