Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAP4 and non-filesystem based dataset #568

Closed
lesserwhirls opened this issue Feb 12, 2025 · 0 comments · Fixed by #570
Closed

DAP4 and non-filesystem based dataset #568

lesserwhirls opened this issue Feb 12, 2025 · 0 comments · Fixed by #570
Labels
bug Something isn't working service:dap4 DAP4 protocol
Milestone
v5.7

Comments

@lesserwhirls
Copy link
Collaborator

The dap4 code needs a slight refactor to allow for thredds.server.dap4.Dap4Controller to use thredds.core.TdsRequestedDataset for reading data as NetcdfFile. This will allow the use of dap4 on virtual datasets (e.g. NcML aggregations), as well as handle authentication/authorization in the same way as other services.
@lesserwhirls lesserwhirls added bug Something isn't working service:dap4 DAP4 protocol labels Feb 12, 2025
@lesserwhirls lesserwhirls added this to the v5.7 milestone Feb 12, 2025
lesserwhirls added a commit to lesserwhirls/tds that referenced this issue Feb 12, 2025
@lesserwhirls
Refactor DAP4 CDM file reading
148da6d 
Previously, reading datasets via the CDM was reliant upon extracting a
filesystem path from the incoming request through implementation of the
abstract method dap4.servlet.DapController#getResourcePath. This has
been refactored to use dap4.servlet.DapController#getCDMWrap as the
abstract method used to interface the CDM reading code. D4TS continues
to use the getResourcePath code in its implementation of getCDMWrap. The
TDS utilizes TdsRequestedDataset in its implementation, which takes care
of virtual datasets, such as NcML aggregations, object storage based
data, etc., as well as authentication/authorization.

Fixes Unidata#568
@lesserwhirls lesserwhirls mentioned this issue Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working service:dap4 DAP4 protocol
Projects
None yet
Milestone
v5.7
Development

Successfully merging a pull request may close this issue.

Refactor DAP4 CDM file reading lesserwhirls/tds
1 participant
@lesserwhirls