Refactor DAP4 CDM file reading #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, reading datasets via the CDM was reliant upon extracting a filesystem path from the incoming request through implementation of the abstract method dap4.servlet.DapController#getResourcePath. This has been refactored to use dap4.servlet.DapController#getCDMWrap as the abstract method used to interface the CDM reading code. D4TS continues to use the getResourcePath code in its implementation of getCDMWrap. The TDS utilizes TdsRequestedDataset in its implementation, which takes care of virtual datasets, such as NcML aggregations, object storage based data, etc., as well as authentication/authorization. Fixes Unidata#568
DennisHeimbigner
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, reading datasets via the CDM was reliant upon extracting a filesystem path from the incoming request through implementation of the abstract method dap4.servlet.DapController#getResourcePath. This has been refactored to use dap4.servlet.DapController#getCDMWrap as the abstract method used to interface the CDM reading code. D4TS continues to use the getResourcePath code in its implementation of getCDMWrap. The TDS utilizes TdsRequestedDataset in its implementation, which takes care of virtual datasets, such as NcML aggregations, object storage based data, etc., as well as authentication/authorization.
Fixes #568