Skip to content

Use monotonic clock and inclusive lower bounds in dart_async test #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chavic merged 1 commit into from
Sep 2, 2026
Merged

Use monotonic clock and inclusive lower bounds in dart_async test #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions fixtures/dart_async/test/futures_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ import 'package:test/test.dart';
import '../dart_async.dart';

Future<Duration> measureTime(Future<void> Function() action) async {
final start = DateTime.now();
final stopwatch = Stopwatch()..start();
await action();
final end = DateTime.now();
return end.difference(start);
stopwatch.stop();
return stopwatch.elapsed;
}

// The DELAY-based timing assertions below check a LOWER bound only: that an
Expand Down Expand Up @@ -93,7 +93,7 @@ void main() {
await sleep(ms: 200);
});

expect(time.inMilliseconds > 200, true);
expect(time.inMilliseconds >= 200, true);
});

test('sequential_future', () async {
Expand All @@ -103,7 +103,7 @@ void main() {
expect(resultAlice, 'Hello, Alice!');
expect(resultBob, 'Hello, Bob!');
});
expect(time.inMilliseconds > 300, true);
expect(time.inMilliseconds >= 300, true);
});

test('concurrent_future', () async {
Expand Down Expand Up @@ -153,7 +153,7 @@ void main() {
final resultAlice = await sayAfterWithTokio(ms: 200, who: 'Alice');
expect(resultAlice, 'Hello, Alice (with Tokio)!');
});
expect(time.inMilliseconds > 200, true);
expect(time.inMilliseconds >= 200, true);
});

test('fallible_function_and_method', () async {
Expand Down
Loading