Conversation
chavic
force-pushed
the
fix/disposal-guards
branch
from
September 11, 2026 16:02
4d48b3e to
d1fc88b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #70. Calling
dispose()twice currently frees the same Rust handle again, and calling a method afterwards can clone that freed handle.This adds a disposed state to regular objects, Rust-only trait wrappers, and Rust-backed foreign traits. A second
dispose()becomes a no-op, while later calls or lowering through that wrapper throwStateErrorbefore reaching Rust. Another wrapper holding its own reference remains usable.I've added tests for repeated disposal, use after disposal, native drop counts, and independently owned trait handles. Both fixture suites passed: 23 Dart tests, including the three new cases. Formatting and diff checks passed too.
This addresses the disposal guards in #70. The wider buffer cleanup and argument rollback work still needs its own fixes.