add test

Uniswap · Nov 5, 2024 · 9c2531f · 9c2531f
1 parent 3633229
commit 9c2531f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts b/lib/handlers/router-entities/route-caching/dynamo-route-caching-provider.ts
@@ -167,7 +167,7 @@ export class DynamoRouteCachingProvider extends IRouteCachingProvider {
   ): CachedRoutes {
     metric.putMetric(`RoutesDbEntriesFound`, result.Items!.length, MetricLoggerUnit.Count)
     const cachedRoutesArr: CachedRoutes[] = result.Items!.map((record) => {
-      if (record.plainRoutes?.toString().trim() !== '') {
+      if (record.plainRoutes && record.plainRoutes?.toString().trim() !== '') {
         metric.putMetric(`RoutesDbEntryPlainTextRouteFound`, 1, MetricLoggerUnit.Count)
 
         const cachedRoutesJson = JSON.parse(record.plainRoutes)

diff --git a/.../mocha/integ/handlers/router-entities/route-caching/dynamo-route-caching-provider.test.ts b/.../mocha/integ/handlers/router-entities/route-caching/dynamo-route-caching-provider.test.ts
@@ -175,6 +175,7 @@ describe('DynamoRouteCachingProvider', async () => {
 
   it('Cached routes hits new cached routes lambda', async () => {
     spy.withArgs('CachingQuoteForRoutesDbRequestSentToLambdanewcachinglambda', 1, MetricLoggerUnit.Count)
+    spy.withArgs('RoutesDbEntryPlainTextRouteFound', 1, MetricLoggerUnit.Count)
 
     // testnet rolls out at 100%
     const newCachedRoutesRolloutPercent = NEW_CACHED_ROUTES_ROLLOUT_PERCENT[ChainId.SEPOLIA]