-
Notifications
You must be signed in to change notification settings - Fork 235
feat: allowlist Ring Protocol hooks on Ethereum #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
lib/util/hooksAddressesAllowlist.ts
Outdated
| // example pool: https://app.uniswap.org/explore/pools/ethereum/0x9c193659e9c8e7a801eaadfd3d61cca35239955fcc04e996a770d28805d21d4d | ||
| export const RING_FEW_ETH_HOOK_ON_MAINNET = '0x12b504160222D66c38d916d9FbA11B613c51E888' | ||
| export const RING_FEW_UNI_HOOK_ON_MAINNET = '0xCF1E7189264a84D7454077dC713c3d11400de888' | ||
| export const RING_FEW_WBTC_HOOK_ON_MAINNET = '0x948922B055187c7366E71B876aB1242EBBAeA888' | ||
| export const RING_FEW_CBBTC_HOOK_ON_MAINNET = '0x28416B4c065e877E7c0BfF17ab1f67C6527D6888' | ||
| export const RING_FEW_USDC_HOOK_ON_MAINNET = '0x1989CdAb2779ed83c0C81A5799FF6aF2e03c6888' | ||
| export const RING_FEW_USDT_HOOK_ON_MAINNET = '0x9590a832d08545AaD4F2A148f3eEFA6EDe1C2888' | ||
| export const RING_FEW_DAI_HOOK_ON_MAINNET = '0x90828f70070d84Ac5CDE145b27Ca75FDa6D02888' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
also can quote through https://app.warp.dev/block/aqtnQpvZkqdIUyVeu9Io2S, but see the simulation failure. simulation failure happens when we submit to tenderly for the simulated universal router swaps. See trace https://www.tdly.co/shared/simulation/82298416-2c64-4fba-8cca-0c20b22ac5af |
Actually this time it succeeds https://www.tdly.co/shared/simulation/dc94ef9f-b7c2-435f-a3c1-c8d9c5a704a1 |
|
None of the pools provided in the description are hooked pools, just standard pools between two assets. Some of the hooked pools appear to be: We need to retest simulation through one of these pools to confirm the hook is routable. Routing is already available through the non-hooked pools |
Hook addresses:
0x12b504160222D66c38d916d9FbA11B613c51E8880xCF1E7189264a84D7454077dC713c3d11400de8880x948922B055187c7366E71B876aB1242EBBAeA8880x28416B4c065e877E7c0BfF17ab1f67C6527D68880x1989CdAb2779ed83c0C81A5799FF6aF2e03c68880x9590a832d08545AaD4F2A148f3eEFA6EDe1C28880x90828f70070d84Ac5CDE145b27Ca75FDa6D02888Uniswap App pages for the hooked pools: