Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add send method metrics #707

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented May 22, 2024

Our new provider is asking whether we can have a break of methods via send RPC invocations. We are logging such metric. Also clean up the log.error to include the error object, so that the error callstack can also be logged for easier debugging.

@jsy1218 jsy1218 changed the title add send method metrics chore: add send method metrics May 22, 2024
Copy link
Member Author

jsy1218 commented May 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 marked this pull request as ready for review May 22, 2024 19:00
@graphite-app graphite-app bot requested review from uni-guillaume and a team May 22, 2024 19:02
@graphite-app graphite-app bot requested review from mikeki and cgkol May 22, 2024 19:02
Copy link

graphite-app bot commented May 22, 2024

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (05/22/24)

1 assignee was added and 5 reviewers were added to this PR based on 's automation.

@jsy1218 jsy1218 merged commit fa55a81 into main May 22, 2024
5 checks passed
@jsy1218 jsy1218 deleted the jsy1218/log-send-method-metrics branch May 22, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants