Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add quicknodetest_1 into the secret fetch list #725

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Jun 6, 2024

Forgot to add quicknodetest_1 into the secret fetch list, so that we hit runtime error:

2024-06-06T22:10:25.844Z	undefined	ERROR	Unhandled Promise Rejection 	{"errorType":"Runtime.UnhandledPromiseRejection","errorMessage":"Error: Environmental variable QUICKNODETEST_1 isn't defined!","reason":{"errorType":"Error","errorMessage":"Environmental variable QUICKNODETEST_1 isn't defined!","stack":["Error: Environmental variable QUICKNODETEST_1 isn't defined!","    at Function.validateProdConfig (/lib/rpc/GlobalRpcProviders.ts:36:17)","    at Function.getGlobalUniRpcProviders (/lib/rpc/GlobalRpcProviders.ts:121:43)","    at <anonymous> (/lib/handlers/injector-sor.ts:168:35)","    at h (/node_modules/lodash/lodash.js:653:23)","    at Function.Kk (/node_modules/lodash/lodash.js:9622:14)","    at Zie.buildContainerInjected (/lib/handlers/injector-sor.ts:166:11)","    at Zie.build (/lib/handlers/handler.ts:51:41)","    at Object.<anonymous> (/lib/handlers/index.ts:13:74)","    at Module._compile (node:internal/modules/cjs/loader:1364:14)","    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)"]},"promise":{},"stack":["Runtime.UnhandledPromiseRejection: Error: Environmental variable QUICKNODETEST_1 isn't defined!","    at process.<anonymous> (file:///var/runtime/index.mjs:1276:17)","    at process.emit (node:events:517:28)","    at process.emit (node:domain:489:12)","    at emit (node:internal/process/promises:149:20)","    at processPromiseRejections (node:internal/process/promises:283:27)","    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)"]}

Copy link
Member Author

jsy1218 commented Jun 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 marked this pull request as ready for review June 6, 2024 22:15
@graphite-app graphite-app bot requested review from xrsv, a team, mikeki, cgkol and uni-guillaume June 6, 2024 22:16
Copy link

graphite-app bot commented Jun 6, 2024

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (06/06/24)

6 reviewers were added and 1 assignee was added to this PR based on 's automation.

@jsy1218 jsy1218 force-pushed the jsy1218/fix-quicknodetest_1_fetch branch from 0303785 to b020510 Compare June 6, 2024 22:25
Copy link
Member Author

jsy1218 commented Jun 6, 2024

Merge activity

  • Jun 6, 6:26 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 6, 6:28 PM EDT: @jsy1218 merged this pull request with Graphite.

@jsy1218 jsy1218 merged commit d048796 into main Jun 6, 2024
5 checks passed
@jsy1218 jsy1218 deleted the jsy1218/fix-quicknodetest_1_fetch branch June 6, 2024 22:28
xumoyan pushed a commit to xumoyan/routing-api that referenced this pull request Aug 20, 2024
* 'main' of github.com:xumoyan/routing-api: (155 commits)
  fix: bump lambda version to pick up new zksync secret (Uniswap#730)
  feat: support routing on zksync (Uniswap#729)
  feat: double sampling tenderly node estimate gas api (Uniswap#728)
  chore: remove quicknodetest_1 sampling (Uniswap#727)
  feat: shadow tenderly new node endpoint (Uniswap#726)
  fix: add quicknodetest_1 into the secret fetch list (Uniswap#725)
  fix: bump lambda version to pick up secrets in env var (Uniswap#724)
  fix: quicknode test key naming (Uniswap#723)
  chore: shadow sampling mainnet traffic to quicknode test key (Uniswap#722)
  chore(subgraph-cache): Increase retries on decentralized network endpoints (Uniswap#721)
  chore: remove nirvana from sampling and 5x alchemy sampling traffic (Uniswap#720)
  chore(subgraph): Use decentralized network arbitrum subgraph (Uniswap#719)
  chore: increase alchemy shadow sampling by 10x (Uniswap#718)
  fix(cache job): Switch to the uniswap-v2-dev subgraph (Uniswap#717)
  fix(caching): Try older version of subgraph (Uniswap#716)
  fix(caching): Use decentralized network v2 subgraph on Mainnet (Uniswap#715)
  chore(cron): Migrate Polygon to Alchemy (Uniswap#714)
  Revert "fix: manually filter out fantom cached routes (Uniswap#712)" (Uniswap#713)
  fix: manually filter out fantom cached routes (Uniswap#712)
  fix: bump lambda version to pick up the new s3 subgraph pool files (Uniswap#711)
  ...

# Conflicts:
#	bin/app.ts
#	bin/stacks/routing-api-stack.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants