posm deploy script #294
Merged
posm deploy script #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
previously approved these changes
Aug 12, 2024
hensha256
reviewed
Aug 12, 2024
script/DeployPosm.s.sol
Outdated
| function run(address poolManager, address permit2) public returns (PositionManager posm) { | ||
| vm.startBroadcast(); | ||
|
|
||
| // TODO: remove salt when we have a deployed version on sepolia |
There was a problem hiding this comment.
dm-ed you for your thoughts about todos
saucepoint
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
want to merge #293 first