Skip to content

[HDRP] Fixed box shape spotlight range attenuation does not work in volumetric lighting - #8101

Closed
Minghou-Lei wants to merge 0 commit into
Unity-Technologies:masterfrom
Minghou-Lei:master
Closed

[HDRP] Fixed box shape spotlight range attenuation does not work in volumetric lighting#8101
Minghou-Lei wants to merge 0 commit into
Unity-Technologies:masterfrom
Minghou-Lei:master

Conversation

@Minghou-Lei

Copy link
Copy Markdown
Contributor

Volumetric lighting box light range attenuation calculation doesn't sync with Deferred lighting box light range attenuation calculation:

In PunctualLightCommon.hlsl::GetPunctualLightVectors
(Main_–_PunctualLightCommon hlsl)2024-September23_11-57-08-820

In VolumetricLighting.compute:
image

Before commit:
image

After commit:
image

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant