Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDRP - Fix bad hyperlink in Graphics Settings tutorial (page 6) #8113

Merged

Conversation

YohannVaastUnity
Copy link
Contributor

@YohannVaastUnity YohannVaastUnity commented Dec 4, 2024

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

  • Fixed the broken hyperlink (JIRA Ticket)
  • Fixed a few typos in the text
  • Fixed an outdated tutorial (JIRA Ticket)

Testing status

Tested manually, using this repository and the test project directly.


Comments to reviewers

@markg-unity markg-unity requested review from ocarrere and removed request for markg-unity January 24, 2025 12:06
assigned to the project.\n\n2. Disable HDRI Sky. \n\nSee that the Sky in
Go to <b>Edit</b> > <b>Project Settings</b> > <b>Graphics</b> > <b>Pipeline
Specific Settings</b> > <b>HDRP</b> and review the <b>Default Profile</b>
assigned to the project.\n\n2. In the scene, through the <i>Hierarchy</i>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is \n2 valid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's simply a line break followed by a number, marking a step in a numbered list.

@YohannVaastUnity YohannVaastUnity requested review from UnityAljosha and removed request for ocarrere February 5, 2025 19:33
@YohannVaastUnity
Copy link
Contributor Author

Hey @UnityAljosha,
This one should be ready to land!

@UnityAljosha UnityAljosha merged commit 638611e into master Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants