Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ClearPartBindings to BindingSyntax #1360

Conversation

steinbitglis
Copy link

Description

This adds a method to BindingSyntax that removes/clears all the part bindings of a composite binding.

Changes made

The added method (ClearBindingParts) replaces code similar to this:

        void ClearBindingParts (BindingSyntax b) {
            if (b.valid)
                b = b.NextBinding();
            while (b.valid && b.binding.isPartOfComposite)
                b.Erase();
        }

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@steinbitglis
Copy link
Author

steinbitglis commented Oct 4, 2021

I guess that in theory it could be an extension method, but it uses a lot of internal fields and stuff, so it makes more sense a proper method.

@jimon
Copy link
Contributor

jimon commented Feb 13, 2023

Hi, thanks for your contribution! We gonna proceed with merging it with slight tweaks in #1641

@jimon jimon closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants