FIX: InputActionReference when using FEPM (ISX-1968)

[timkeo]

Description

When Domain Reloads are disabled, InputActionReference instances continue to reference the "old" InputAction object from the previous PlayMode session. This fix clears the InputAction reference when exiting PlayMode allowing it to be reloaded in the next session.

Although Configurable PlayMode options, aka Fast Enter PlayMode, isn't currently supported, a number of tickets have been filed against this issue including:

• ISXB-601
• ISXB-718
• ISXB-900
• ISXB-469
• ISXB-598

indicating FEPM is quite a popular feature and fixing this issue is beneficial to our customers.

Furthermore, the underlying problem is a bug in its own right regardless of FEPM: the underlying Action instance is invalid for EditMode and holding the reference is dangerous as it keeps the object "alive" along with the pointers to native memory buffers that are de-allocated when exiting PlayMode. In short, attempting to access the ActionReference after leaving PlayMode can cause an AV and crash the Editor.

Changes made

When exiting PlayMode, all InputActionReference instances are queried and their m_Action field is reset. This forces a "reload" of the Action from the Asset the next time its accessed just as if a Domain Reload had occured.

Notes

This issue is completely separate from my CoreCLR refactor and can be fixed independently of it.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
  • FogBugz is marked as "Resolved" with next release version correctly set.
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

After merge:

• Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

[Pauliusd01]

LTGM, made sure that the mentioned bugs are fixed, ran through a few testing scenes with the domain reload disabled, including ones that save things such as rebinding menus. Did not see any issues.

[ekcoh]

Excellent PR description and great to get this fixed. LGTM

[timkeo]

The tvOS failure is a per-existing issue and unrelated to the PR, which is an Editor fix that doesn't affect Players.