FIX: Arrow key navigation of Input Actions after Action rename. #2082
+98
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekcoh
approved these changes
Dec 9, 2024
| @@ -173,5 +189,51 @@ public IEnumerator CanDeleteActionMap() | |||
| Assert.That(m_Window.currentAssetInEditor.actionMaps[0].name, Is.EqualTo("First Name")); | |||
| Assert.That(m_Window.currentAssetInEditor.actionMaps[1].name, Is.EqualTo("Third Name")); | |||
| } | |||
|
|
|||
| [UnityTest] | |||
| public IEnumerator CanRenameAction() | |||
There was a problem hiding this comment.
Awesome you've added a proper editor test for this. Thank you!
tspiller
force-pushed
the
isxb-1024-action-navigation-after-rename
branch
from
6181acc to
249949b
Compare
Pauliusd01
requested changes
Dec 10, 2024
|
If you duplicate while in rename mode that action stays in rename mode instead of cancelling it 10.12.2024.-.Unity.68.mp4 |
|
Odd behaviour after renaming a map -> action and then action again 10.12.2024.-.Unity.69.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ActionsTreeView should use RefreshItems in Unity 6000.0 onwards to have the same behaviour as ActionMapsView. This allows keyboard navigation after renaming.
It is not a perfect fix, as the limitations of UIToolkit and InputSystem refresh mean that the action will still lose focus occasionally. However this is the current behaviour of Action Maps and Actions should match that as closely as possible.
Testing status & QA
Local Testing.
Added new CanRenameAction test.
Overall Product Risks
Complexity: Low
Halo Effect: None
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: