Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Mark Action Maps and Actions as disabled for renaming when in cut mode #2088

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tspiller
Copy link
Collaborator

Description

Both Action Maps and Actions can currently be renamed when already in Cut Mode. This leaves them in a state where they cannot exit the rename selection until another Action Map/Action is selected.
It is not expected to be able to rename elements when they are already cut - it could invalidate the currently cut data and this behaviour is not see elsewhere in the Editor.

This PR marks the elements as disabled and prevents rename mode being entered.

Testing status & QA

Local testing.

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low - Disables the possibility of renaming, should not introduce anything new

Comments to reviewers

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@tspiller tspiller changed the title Mark Action Maps and Actions as disabled for renaming when in cut mode FIX: Mark Action Maps and Actions as disabled for renaming when in cut mode Dec 13, 2024
@ekcoh
Copy link
Collaborator

ekcoh commented Dec 20, 2024

@tspiller Just wanted to double check this is intended to be in draft state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants