FIX: Modifying or changing focus on composite bindings in the Input Actions Editor no longer cause a full UI rebuild #2094
+23
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ISXB-1171.
The issue was caused by the on change handler causing a full UI rebuild of the editor window when it was not required. The fix required added a new enum which told the UI system if a rebuild was necessary - defaulting to rebuilding since this was the previous default.
Testing status & QA
This was tested locally using the provided project. The change is localised to the composite binding part of the window and so I don't believe additional QA would be required.
Overall Product Risks
Comments to reviewers
The only concern I have with this solution is - do we know of any instances where changes to the UI would require a complete rebuild?
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: