Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: WIP Set macOS Xbox gamepad based on PID/VID #2097

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jfreire-unity
Copy link
Collaborator

@jfreire-unity jfreire-unity commented Dec 20, 2024

Description

An attempt to fix https://jira.unity3d.com/browse/ISXB-1264 in case @ieuanrees validates that this button mapping works.

Only for macOS since Windows uses XInput.
So far it only does this for a particular PID VID group and can likely be expanded and improved.

Ideally we could probably expand the coverage by using this database and define the layouts accordingly for Xbox controllers.

Testing status & QA

Overall Product Risks

Unclear what other combinations of PID/VID we are missing.

  • Complexity: Minimal
  • Halo Effect: Low

Comments to reviewers

In general, I don't like this approach since I'm creating a lot of duplication.
But if this solves the original bug while introducing regressions, I'm open to discuss a better approach with the team (after holidays)

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

Only for macOS since Windows uses XInput.
So far it only does this for a particular PID VID group and can likely be expanded and improved.
@jfreire-unity jfreire-unity force-pushed the isxb-1264-fix-different-xbox-macos-different-button-mapping branch from 7da428c to 41d5a3f Compare December 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant