FIX: fixed gamepad navigation in UI Toolkit TextField

[benoitalain]

Description

Fixed UUM-77364: fixed gamepad navigation in UI Toolkit TextField when using InputSystemUIInputModule.

Testing status & QA

Tested issue and fix manually. Modified unit test to include IsKeyboardNavigationEvent check.

Overall Product Risks

• Complexity: medium
• Halo Effect: low

Comments to reviewers

Requires prior landing of trunk PR: https://github.cds.internal.unity3d.com/unity/unity/pull/59210.

Asmdef define for UNITY_INPUT_SYSTEM_INPUT_MODULE_NON_KEYBOARD needs to be adjusted once that PR has landed.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

After merge:

• Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

[ekcoh]

Code changes LGTM, thanks for addressing this.

[ekcoh]

Seems like it doesn't compile cleanly (CI failures) that needs to be looked into, maybe you are expected types that doesn't exist on older versions? Suspect this is why you added the new conditional symbol define. Also seem to have file conflict.

[benoitalain]

Seems like it doesn't compile cleanly (CI failures) that needs to be looked into, maybe you are expected types that doesn't exist on older versions? Suspect this is why you added the new conditional symbol define. Also seem to have file conflict.

The corresponding trunk PR needs to land first. Also, I will adjust the asmdef define constraint when it has landed, since I can't know what it is for sure before that.