Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1629: pantilt recentering was ignoring axis center setting #1029

Merged

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Dec 19, 2024

Purpose of this PR

CMCL-1629: PanTilt recentering was ignoring axis center setting. Was using hardcoded (0, 0).

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (ba4cc2b) to head (f955c06).
Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
...nemachine/Runtime/Components/CinemachinePanTilt.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
+ Coverage   26.97%   27.21%   +0.24%     
==========================================
  Files         254      254              
  Lines       28418    28485      +67     
==========================================
+ Hits         7665     7753      +88     
+ Misses      20753    20732      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute requested a review from alexzaranek January 7, 2025 15:15
@glabute glabute merged commit ae7b8e7 into main Jan 8, 2025
67 of 69 checks passed
@glabute glabute deleted the dev/pantilt-recentering-was-ignoring-axis-center-setting branch January 8, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants