Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1631: FramingTransposer with a dead zone would sometimes drift #1031

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CMCL-1631: FramingTransposer with a dead zone would sometimes drift #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.cinemachine/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Bugfixes
- CameraDeactivated events were not sent consistently when a blend interrupted another blend before completion.
- CameraActivated events were not sent consistently when activation was due to timeline blends.
- Bugfix: FramingTransposer with a dead zone would sometimes drift.


## [3.1.2] - 2024-10-01
Expand Down
2 changes: 1 addition & 1 deletion com.unity.cinemachine/Runtime/Components/CinemachinePositionComposer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ public override void MutateCameraState(ref CameraState curState, float deltaTime
realTargetPos - cameraOffset, hardGuideOrtho);
}
}
curState.RawPosition = localToWorld * (cameraPos + cameraOffset);
curState.RawPosition = camPosWorld + localToWorld * cameraOffset;
m_PreviousCameraPosition = curState.RawPosition;

m_InheritingPosition = false;
Expand Down
2 changes: 1 addition & 1 deletion com.unity.cinemachine/Runtime/Deprecated/CinemachineFramingTransposer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ public override void MutateCameraState(ref CameraState curState, float deltaTime
realTargetPos - cameraOffset, hardGuideOrtho);
}
}
curState.RawPosition = localToWorld * (cameraPos + cameraOffset);
curState.RawPosition = camPosWorld + localToWorld * cameraOffset;
m_PreviousCameraPosition = curState.RawPosition;

// Adjust lens for group framing
Expand Down
Loading