CMCL-1634: decollider would sometimes cause camera to slip inside cracks between adjacent colliders #1033
+71
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… between adjacent colliders
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
+ Coverage 26.97% 27.21% +0.24%
==========================================
Files 254 254
Lines 28418 28485 +67
==========================================
+ Hits 7665 7753 +88
+ Misses 20753 20732 -21 ☔ View full report in Codecov by Sentry. |
sebastienduverne
approved these changes
Jan 14, 2025
style Co-authored-by: Sébastien Duverne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
CMCL-1634: decollider would sometimes cause camera to slip inside cracks between adjacent colliders
This is because the collider detection algorithm was inadequate. Algorithm was reworked to be more robust around colliders made up of multiple adjacent colliders. Camera will only go into the crack if the crack is wider than the camera radius specified in the Decollider.
Bonus: smoothing logic was also simplified and corrected, fixing an intermittent bug that caused the camera to sometimes snap out of its smoothed position, bypassing damping. That bug was unreported.
Testing status
Documentation status
Technical risk
low
Comments to reviewers
Please see test scene in the Jira ticket.