Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1618: Fix default GameController mapping + zoom input functionality #1034

Merged
merged 16 commits into from
Jan 17, 2025

Conversation

alexzaranek
Copy link
Contributor

@alexzaranek alexzaranek commented Jan 10, 2025

Purpose of this PR

CMCL-1618: Fix default GameController mapping

This PR addresses a number of issues with the default input mappings provided in the Cinemachine package. The updates included are:

  • Renamed the Action Map of the Cinemachine Default Input Actions asset from Player to CM Default to make it clear that these actions originate from the Cinemachine package and not the Player default input actions from the Input System package.
  • Removed the negative inversion from the gamepad x axis input.
  • Changed the Aim input action on the gamepad to use the left trigger rather than the right shoulder button.
  • Changed the Jump input action on the gamepad to use the A button rather than the Y button.
  • Changed the Sprint input action on the gamepad to use the X button rather than the A button.
  • Fixed the Radial Axis input axis (mapped to the Zoom action) in the Orbital Follow component to map to the y axis rather than the x axis.
  • Updated the default radial range max value from 1 to 3.
  • Reduced the default Legacy Gain value for non-momentary inputs from 200 to 50.
  • Updated the sample projects with the improvements listed above.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

Low

@alexzaranek alexzaranek requested a review from glabute as a code owner January 10, 2025 21:31
@unity-cla-assistant
Copy link

unity-cla-assistant commented Jan 10, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ glabute
❌ alexzaranek
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.24%. Comparing base (ba4cc2b) to head (4d277f0).
Report is 80 commits behind head on main.

Files with missing lines Patch % Lines
...achine/Editor/Editors/InputAxisControllerEditor.cs 50.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
+ Coverage   26.97%   27.24%   +0.26%     
==========================================
  Files         254      254              
  Lines       28418    28500      +82     
==========================================
+ Hits         7665     7764      +99     
+ Misses      20753    20736      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sebastienduverne sebastienduverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog ok + doesn't seem to affect docs.

Copy link
Collaborator

@glabute glabute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked the legacy settings a bit

@glabute glabute merged commit 2959919 into main Jan 17, 2025
2 of 69 checks passed
@glabute glabute deleted the dev/input-asset-clean-up branch January 17, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants