Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null bufferview with zero'd data #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix null bufferview with zero'd data #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions Runtime/Scripts/GltfImport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1872,6 +1872,21 @@ async Task<bool> LoadGltfBinaryBuffer(byte[] bytes, Uri uri = null)
return true;
}

unsafe void* GetZeroBuffer(int bytes)
{
byte[] zeroBuffer = new byte[bytes];
// Fill with zeros
for (int i = 0; i < bytes; i++)
{
zeroBuffer[i] = 0;
}

fixed (byte* bufferAddress = &zeroBuffer[0])
{
return bufferAddress;
}
}

byte[] GetBuffer(int index)
{
return m_Buffers[index];
Expand Down Expand Up @@ -4105,8 +4120,14 @@ unsafe void IGltfBuffers.GetAccessor(int index, out AccessorBase accessor, out v
accessor = Root.Accessors[index];
if (accessor.bufferView < 0 || accessor.bufferView >= Root.BufferViews.Count)
{
data = null;
byteStride = 0;
if (accessor.IsSparse)
{
data = null;
byteStride = 0;
return;
}
data = GetZeroBuffer(accessor.ByteSize);
byteStride = AccessorBase.GetComponentTypeSize(accessor.componentType);
return;
}
var bufferView = Root.BufferViews[accessor.bufferView];
Expand Down