fix: remove ServerAnimationHandler OnNetworkSpawn workaround [MTT-3152] #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
2-Easy
|
Threw this PR up but it should wait until after this PR goes through for the 2.0.3 release. |
| @@ -1,5 +1,4 @@ | |||
| using System; | |||
|
We can't quite yet remove the workaround, since applying a change to the NetworkAnimator on OnNetworkSpawn() will currently throw NullReferenceExceptions. This PR addresses that issue, meaning this PR will go on hold for now. |
fernando-cortez
added
the
4-On Hold
|
This PR has included the work that this PR was aiming to initially accomplish, and so I'll close this PR. |
fernando-cortez
deleted the
fix/remove-serveranimationhandler-workaround
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a previous workaround that previously synced life state for players. A joining player would not see a fully synced Animator. The cases where this was obvious was when a late joiner would not see fainted players in their fainted animation. This has since been fixed on the NetworkAnimator side and so this workaround is not necessary.
Issue Number(s)
MTT-3152
Contribution checklist