Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UNITY_WIN_PLATFORM and use for platform check (case UUM-73753). #2045

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

joncham
Copy link
Member

@joncham joncham commented Jun 28, 2024

2022.3 Backport: #2038

Similar change was done for unity-aot profile here 05281d8

Minimal version of initial proposed fix here #2033

  • Should this pull request have release notes?
    • Yes
    • No
  • Do these changes need to be back ported?
    • Yes
    • No
  • Do these changes need to be upstreamed to mono/mono or dotnet/runtime repositories?
    • Yes
    • No

Reviewers: please consider these questions as well! ❤️

Release notes

Fixed UUM-73753 @joncham :
Mono: Fix exception when using System.IO.Compression.BrotliStream on Android.

Backports
2023.3, 2022.3, 2021.3

Minimal fix to correct platform detection, as all platform unityjit
profiles have WIN_PLATFORM already defined.
@joncham joncham self-assigned this Jun 28, 2024
@joncham joncham requested a review from UnityAlex July 1, 2024 19:03
@joncham joncham merged commit 74d8162 into unity-2021.3-mbe Jul 1, 2024
9 checks passed
@joncham joncham deleted the unity-2021.3-mbe-fix-uum-73753-2 branch July 1, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants