Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unity main 8.0 sync #267

Closed
wants to merge 408 commits into from
Closed

Unity main 8.0 sync #267

wants to merge 408 commits into from

Conversation

UnityAlex
Copy link
Collaborator

No description provided.

dotnet-maestro bot and others added 30 commits February 21, 2024 19:18
@dotnet-maestro
[release/8.0-staging] Update dependencies from dotnet/runtime-assets (d…
2ebbc77 
…otnet#98560)

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240215.2

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.24108.4 -> To Version 8.0.0-beta.24115.2

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240215.2

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.24108.4 -> To Version 8.0.0-beta.24115.2

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240215.2

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.24108.4 -> To Version 8.0.0-beta.24115.2

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240215.2

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.24108.4 -> To Version 8.0.0-beta.24115.2

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240215.2

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.24108.4 -> To Version 8.0.0-beta.24115.2

* Update dependencies from https://github.com/dotnet/runtime-assets build 20240215.2

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.24108.4 -> To Version 8.0.0-beta.24115.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20240…
c3a4e13 
…213.2 (dotnet#98445)

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24059.4 -> To Version 8.0.0-beta.24113.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
b41d2b6 
…40212.2 (dotnet#98444)

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 8.0.0-prerelease.24060.1 -> To Version 8.0.0-prerelease.24112.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@carlossanlop
Merge pull request dotnet#98454 from dotnet-maestro-bot/merge/release…
eb8f371 
…/8.0-to-release/8.0-staging

[automated] Merge branch 'release/8.0' => 'release/8.0-staging'
@hoyosjs
Update diasymreader to 17.8.7-beta1.24113.1 (dotnet#98539)
a3de6b7
@github-actions
[mono] Set /DEBUGTYPE:CV,FIXUP on binaries (dotnet#99356)
2760222 
This fixes an issue with running APIScan on mono-aot-cross.exe
@vseanreesermsft
Update branding to 8.0.4 (dotnet#99324)
13d578b
@dotnet-bot
Merge in 'release/8.0' changes
520bd2e
@github-actions @kg
Restore erroneously removed encoding of the argument count in a gener…
e398dd6 
…ic method instantiation (dotnet#98825)

Users of the multicore jit feature would encounter silent encoding failures while recording profiles due to a defect in our encoding for generic method instances that would make them impossible to decode later. This PR fixes the encoding so that newly-recorded profiles will not be corrupt.

Co-authored-by: Katelyn Gadd <[email protected]>
@dotnet-maestro @lewing @carlossanlop
[release/8.0-staging] Update dependencies from dotnet/emsdk (dotnet#9…
d66d790 
…8458)

* Update dependencies from https://github.com/dotnet/emsdk build 20240214.4

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.3-servicing.24108.3 -> To Version 8.0.3-servicing.24114.4

* Update dependencies from https://github.com/dotnet/emsdk build 20240214.6

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.3-servicing.24108.3 -> To Version 8.0.3-servicing.24114.6

* Update dependencies from https://github.com/dotnet/emsdk build 20240215.2

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.3-servicing.24108.3 -> To Version 8.0.3-servicing.24115.2

* Update dependencies from https://github.com/dotnet/emsdk build 20240227.1

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.3-servicing.24108.3 -> To Version 8.0.3-servicing.24127.1

* Update dependencies from https://github.com/dotnet/emsdk build 20240306.2

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.3-servicing.24108.3 -> To Version 8.0.4-servicing.24156.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
@github-actions @stephentoub @ericstj
[release/8.0-staging] Fix FormatQuantiles formatting in MetricsEventS…
4a1e5f4 
…ource (dotnet#99045)

* Fix FormatQuantiles formatting in MetricsEventSource

These doubles need to be formatted with the invariant culture to meet consumer expectations around parsing them.

* Enable DiagnosticSource for servicing

---------

Co-authored-by: Stephen Toub <[email protected]>
Co-authored-by: Eric StJohn <[email protected]>
@github-actions @MilenaHristova @ViktorHofer
[release/8.0-staging] Add ProducesNetCoreAssets property to Publishin…
db167d9 
…g.props (dotnet#98988)

* add property to publishing.props

* rename to ProducesDotNetReleaseShippingAssets

* Update Publishing.props

* Set assets manifest metadata for assets that get shipped with .NET release (dotnet#98824)

* add metadata to manifest

* set in ItemDefinitionGroup

* remove from items

* comment

---------

Co-authored-by: MilenaHristova <[email protected]>
Co-authored-by: Viktor Hofer <[email protected]>
@ilonatommy
[release/8.0][browser] Fix failures in CalendarTestBase affecting s…
53e2082 
…everal globalization tests (dotnet#99407)

* Partial backport of dotnet#90881.

* Backport updated expected test results.

* Update should be only for v8. Browser/node were correct in the original form.
@dotnet-maestro
[release/8.0-staging] Update dependencies from dotnet/source-build-ex…
1e166b8 
…ternals (dotnet#99481)

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240308.3

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.24065.1 -> To Version 8.0.0-alpha.1.24158.3

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240308.3

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.24065.1 -> To Version 8.0.0-alpha.1.24158.3

* Update dependencies from https://github.com/dotnet/source-build-externals build 20240308.3

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.24065.1 -> To Version 8.0.0-alpha.1.24158.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@github-actions @jakobbotsch
[release/8.0-staging] JIT: Home float parameters before integer param…
ebb4a50 
…eters (dotnet#98749)

* JIT: Home float parameters before integer parameters

Parameters that are going into float registers can come from integer
registers in the presence of struct promotion. We need to home those
before integer parameters or the source register could have been
overridden by the integer parameter homing logic.

Ideally it seems like the homing logic should be unified to handle all
parameters simultaneously, but this seems like a simple enough fix. I do
not think we have ABIs where we have the opposite kind constraint
(integer parameters coming from float registers).

Fix dotnet#96306

* Add test

* Disable float -> int reg enregistration for some rare cases

---------

Co-authored-by: Jakob Botsch Nielsen <[email protected]>
@github-actions @mpidash
[release/8.0-staging] Check if AttributeData for InterfaceTypeAttribu…
c897573 
…te is not null in ConvertComImportToGeneratedComInterfaceAnalyzer (dotnet#98873)

Co-authored-by: Mario Pistrich <[email protected]>
@carlossanlop
Merge pull request dotnet#99374 from dotnet-maestro-bot/merge/release…
7060309 
…/8.0-to-release/8.0-staging

[automated] Merge branch 'release/8.0' => 'release/8.0-staging'
@carlossanlop
[8.0] Reset OOB packages enabled in the March release (dotnet#99569)
0ba49c9 
* Microsoft.Extensions.DependencyInjection.Abstractions

* Microsoft.Extensions.Logging.Abstractions

* Microsoft.Extensions.Options

* System.Text.Json
@carlossanlop
Merge pull request dotnet#99579 from carlossanlop/release/8.0-staging
208b64e 
[manual] Merge release/8.0-staging into release/8.0
@dotnet-bot
Merge in 'release/8.0' changes
367136d
@vseanreesermsft
Merge commit '9f4b1f5d664afdfc80e1508ab7ed099dff210fbd' into internal…
3c13c98 
…-merge-8.0-2024-03-12-1059
@carlossanlop
Update MicrosoftNativeQuicMsQuicVersion to 2.3.5
1207c32
@carlossanlop
Merge pull request dotnet#99627 from vseanreesermsft/internal-merge-8…
e597140 
….0-2024-03-12-1059

Merging internal commits for release/8.0
@dotnet-bot
Merge in 'release/8.0' changes
5cff8b8
@github-actions @stephentoub
Fix AsyncVoidMethodBuilder race condition around SynchronizationConte…
18b5fe6 
…xt (dotnet#99640)

This fixes a long-standing issue we've seen sporadically over the years but for which we just got a solid repro; the symptom is a sporadic unhandled null reference exception that crashes an app when using an async void method builder and a non-default SynchronizationContext. The issue is that, because of how state management is handled in the builder, the builder itself can be cleared while its SetResult method is running, and that means two reads of the _synchronizationContext field can end up returning a non-null value followed by a null value. The fix is to just cache the field into a local before completing the builder, and then only use the local state after.

Co-authored-by: Stephen Toub <[email protected]>
@github-actions @am11
Always keep global symbols on ApplePlatforms (dotnet#99650)
f09cd44 
Co-authored-by: Adeel Mujahid <[email protected]>
@github-actions @vcsjones
Delete Decrypt_Pkcs1_ErrorsForInvalidPadding
c0a2606 
This test has a small random chance of failure because of non-determinism. The test Decrypt_Pkcs1_BadPadding covers this scenario and is properly deterministic, so let's go ahead and delete the test that has a chance of failing.

Co-authored-by: Kevin Jones <[email protected]>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build (dotne…
86f0444 
…t#99716)

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.4-servicing.24156.2 -> To Version 8.0.4-servicing.24163.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-bot
Merge in 'release/8.0' changes
38f2042
@carlossanlop
Rename MSBuild property MicrosoftNativeQuicMsQuicVersion -> Microsoft…
c412efb 
…NativeQuicMsQuicSchannelVersion (dotnet#99714)
alexey-zakharov and others added 19 commits June 20, 2024 09:19
@alexey-zakharov @UnityAlex
Avoid clearing thread local handles for already unloaded loader
c53afdc 
(cherry picked from commit 269c6fb)
@alexey-zakharov @UnityAlex
Exposed coreclr_unity_profiler_get_managed_assembly_load_context API …
a390820 
…to get owning ALC for the AssemblyID
@alexey-zakharov @UnityAlex
Skip ro segments which are not in range when walking heap for GC diag…
ab66012 
…nostics
@vvuk @UnityAlex
Enable FEATURE_PERFMAP on OSX, and update perfjitdump.cpp to work on OSX
8c8c6cb
@vvuk @UnityAlex
Fix up SYS_gettid usage on macOS for jitdump
125b78b
@vvuk @UnityAlex
Keep symbols on macOS in dylibs instead of stripping out to .dwarf files
4c96134
@vvuk @alexey-zakharov @UnityAlex
Update unity/README.md
11cd9c1 
Co-authored-by: Alexey Zakharov <[email protected]>
@vvuk @alexey-zakharov @UnityAlex
Update unity/README.md
e3117ec 
Co-authored-by: Alexey Zakharov <[email protected]>
@joncham @UnityAlex
Add coreclr_unity_set_on_fatal_error.
61ee5dd 
This is a callback that Unity can set to be called when a fatal error
occurs in the CoreCLR. The normal unhandled exception handler and
chaining mechanism is never invoked since CoreCLR exits the process
from a vectored exception handler.
@joncham @UnityAlex
Add coreclr_unity_get_stackframe_info_from_ip.
bcf6eb4
@alexey-zakharov @UnityAlex
Added --keep-native-symbols cmdline option to the build script to kee…
7cbfa76 
…p native Mac symbols for easier profiling and debugging
@alexey-zakharov @UnityAlex
Enable --keep-native-symbols when not running on yamato
ce89b44
@vvuk @UnityAlex
Fixes from upstream effort
3b60422
@alexey-zakharov @UnityAlex
Fixed SzArray from Collectible LoaderAllocator being allocated in fro…
ef470b4 
…zen heap
@alexey-zakharov @UnityAlex
Fixed assert in method checks in debug mode
7615d69
@alexey-zakharov @UnityAlex
Revert "Skip ro segments which are not in range when walking heap for…
6877c0d 
… GC diagnostics"

This reverts commit 3ab6d53.
@alexey-zakharov @UnityAlex
Revert "Fixed SzArray from Collectible LoaderAllocator being allocate…
07d87cc 
…d in frozen heap"

This reverts commit 9c7cc33.
@alexey-zakharov @UnityAlex
Fixed uninitialized EXCEPTION_POINTERS when passing information to Un…
ee11daa 
…ity handler
@alexey-zakharov @UnityAlex
Revert "Avoid clearing thread local handles for already unloaded loader"
7ca4143 
This reverts commit 94c891a.
@UnityAlex
Remove unused APIs
9dadec4 
* mono_assembly_get_image
* mono_metadata_type_equal
* mono_class_array_element_size
* mono_array_element_size
@UnityAlex
Cleanup unused embedding APIs
47d7a16 
Removes the following APIs:
* mono_class_from_mono_type
* mono_class_get_methods
* mono_class_get_parent
* mono_class_get_property_from_name
* mono_class_get_userdata
* mono_debugger_install_attach_detach_callback
* mono_debugger_set_generate_debug_info
* mono_field_get_parent
* mono_signature_get_param_count
* mono_signature_get_params
* mono_signature_get_return_type
* mono_unity_g_free
* coreclr_unity_gc_set_chain_fatal_error
@UnityAlex
Readding type size retrieval to regain lost perf.
b811455
@UnityAlex
Remove unused APIs
39f9749 
* mono_assembly_get_image
* mono_metadata_type_equal
@UnityAlex
Cleanup unused embedding APIs
04d01fb 
Removes the following APIs:
* mono_class_from_mono_type
* mono_class_get_methods
* mono_class_get_parent
* mono_class_get_property_from_name
* mono_class_get_userdata
* mono_debugger_install_attach_detach_callback
* mono_debugger_set_generate_debug_info
* mono_field_get_parent
* mono_signature_get_param_count
* mono_signature_get_params
* mono_signature_get_return_type
* mono_unity_g_free
* coreclr_unity_gc_set_chain_fatal_error
@UnityAlex
Copy link
Collaborator Author

Closing. More up to date PR here: #270

@UnityAlex UnityAlex closed this Sep 26, 2024
@UnityAlex UnityAlex deleted the unity-main-8.0-sync branch September 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-zakharov alexey-zakharov alexey-zakharov approved these changes

@mrvoorhe mrvoorhe Awaiting requested review from mrvoorhe mrvoorhe will be requested when the pull request is marked ready for review mrvoorhe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.