Skip to content

docs: fix .gitignore, architecture.md, add ADR folder and API reference - #126

Merged
dzekojohn4 merged 1 commit into
UnityChainxx:mainfrom
judithJn:fix/judith-issues-113-118-119-120
Jul 25, 2026
Merged

docs: fix .gitignore, architecture.md, add ADR folder and API reference#126
dzekojohn4 merged 1 commit into
UnityChainxx:mainfrom
judithJn:fix/judith-issues-113-118-119-120

Conversation

@judithJn

Copy link
Copy Markdown
Contributor

Summary

Resolves all four open issues assigned to @judithJn in a single docs-focused PR.


Closes #113.gitignore doesn't catch .env, target/, or IDE files

  • Rewrote root .gitignore from 5 lines to comprehensive coverage
  • Now covers: .env / .env.*, Rust target/, IDE directories (.idea/, .vscode/*), OS files (.DS_Store, Thumbs.db), logs, coverage, temp dirs, Docker overrides

Closes #118docs/architecture.md misrepresents current state

  • Pruned backend module list to only modules actually registered in app.module.ts
  • Added explicit note that LeaderboardModule does not exist; the leaderboard endpoint is served by StreakModule
  • Documented that @reduxjs/toolkit is a dependency but Zustand is the active state manager (links to new ADR-0002)
  • Cross-referenced new docs/api.md and docs/adr/
  • Moved unregistered / aspirational modules to a clearly-labelled "not yet registered" section so future contributors have a clear picture

Closes #119 — Add an ADR folder

Created docs/adr/ with four starter ADRs:

File Decision
0001-record-architecture-decisions.md Establishes the ADR process and includes a reusable template
0002-zustand-alongside-redux-toolkit.md Why Zustand is the primary state manager and when to reach for RTK
0003-nestjs-modular-monolith.md Why a modular monolith was chosen over microservices
0004-soroban-over-evm.md Why Soroban / Stellar was chosen over EVM-compatible chains

Closes #120 — API reference table for each public endpoint

Created docs/api.md with a full endpoint reference table derived from the NestJS controller source:

  • Columns: Method · Path · Auth · Description
  • Covers: auth, users, puzzles (game + admin CRUD), puzzle-submission, puzzle-categories, puzzle-dependencies, puzzle-translations, content, rewards, nft-claim, reward-shop, achievements, badges, progress, streaks (authenticated + public), time-trial, in-app-notifications, referrals, challenges, feedback, multiplayer, user-ranking, activity, wallet, admin
  • Points readers to the live Swagger UI (/api/docs) for full request/response schemas

Files Changed

.gitignore                                      (updated)
docs/architecture.md                            (updated)
docs/api.md                                     (new)
docs/adr/0001-record-architecture-decisions.md  (new)
docs/adr/0002-zustand-alongside-redux-toolkit.md (new)
docs/adr/0003-nestjs-modular-monolith.md        (new)
docs/adr/0004-soroban-over-evm.md               (new)

UnityChainxx#120 (gitignore, ADRs, api ref, architecture)

Issue UnityChainxx#113 — Comprehensive root .gitignore
- Expand root .gitignore from 5 lines to full coverage for
  Node/NestJS, Next.js, Rust/Cargo, IDEs, OS files, and secrets
- Adds: .env*, target/, *.local, IDE files (.idea, .vscode/*),
  OS files (Thumbs.db), logs, coverage, temp dirs

Issue UnityChainxx#118 — Fix docs/architecture.md to match reality
- Backend module list pruned to modules actually registered in
  app.module.ts (removed aspirational/non-existent modules)
- Added explicit note that LeaderboardModule does not exist; the
  leaderboard endpoint lives in StreakModule
- Added note that @reduxjs/toolkit is a dependency but Zustand is
  the active state manager; links to ADR-0002
- Cross-referenced new docs/api.md and docs/adr/ folder

Issue UnityChainxx#119 — Add docs/adr/ folder with starter ADRs
- docs/adr/0001-record-architecture-decisions.md: ADR process + template
- docs/adr/0002-zustand-alongside-redux-toolkit.md: why Zustand is primary
- docs/adr/0003-nestjs-modular-monolith.md: why monolith over microservices
- docs/adr/0004-soroban-over-evm.md: why Soroban/Stellar over EVM

Issue UnityChainxx#120 — Create docs/api.md API reference table
- Full endpoint reference derived from NestJS controller source
- Columns: Method, Path, Auth, Description
- Covers auth, users, puzzles, rewards, nft-claim, streak,
  time-trial, notifications, referrals, challenges, feedback,
  wallet, admin and all other registered controllers
- Points to Swagger UI for live request/response schemas
@drips-wave

drips-wave Bot commented Jul 24, 2026

Copy link
Copy Markdown

@judithJn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@dzekojohn4 dzekojohn4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzekojohn4
dzekojohn4 merged commit de33972 into UnityChainxx:main Jul 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants