Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MoveItConfigsBuilder compatible example to ur_moveit_config #917

Closed
5 tasks
odbee opened this issue Jan 30, 2024 · 3 comments · Fixed by #998
Closed
5 tasks

Adding MoveItConfigsBuilder compatible example to ur_moveit_config #917

odbee opened this issue Jan 30, 2024 · 3 comments · Fixed by #998
Labels
enhancement New feature or request

Comments

@odbee
Copy link

odbee commented Jan 30, 2024

Feature summary

Hey, so it seems the current ur_moveit_config folder is not at all compatible with being used with the MoveItConfigsBuilder. It would help greatly with running moveit directly through the C++ API if one could take all the moveitconfigbuilder parameters and add them to the parameters of ones c++ API like this: parameters=[moveit_config.to_dict()]

Tasks

To complete this issue involves

  • Implement the feature
  • Make documentation
  • Make Unit test
  • Make example
  • Test on real hardware
@odbee odbee added the enhancement New feature or request label Jan 30, 2024
@odbee odbee changed the title [FEATURE NAME] Adding MoveItConfigsBuilder compatible example to ur_moveit_config Jan 30, 2024
@VinDp
Copy link
Collaborator

VinDp commented May 8, 2024

Hey @odbee,
thanks for the suggestion, we are currently working on that.
We are going to change the structure according to what is shown in this tutorial page, do you have any opinions on that?

@odbee
Copy link
Author

odbee commented May 8, 2024

Hey @VinDp thanks, for consering my Feature request, looks good! the structure looks good. I think it would be nice to have both scaled_joint_trajectory_controller and regular joint_trajectory_controller available in the "moveit_controllers.yaml", as well as different inverse kinematics ( Trac-IK, Pic IK) and planning (pilz_industrial_motion_planner_planning_planner.yaml , ompl_planner.yaml) files

@odbee odbee closed this as completed May 8, 2024
@odbee odbee reopened this May 8, 2024
@fmauch
Copy link
Collaborator

fmauch commented May 8, 2024

Once issue I see with this is that the robot_name for the robot_description will be different for each robot model (e.g. ur5e. Because of that we currently use an xacro to generate the SRDF. As far as I understand the MoveItConfigsBuilder it doesn't support that but expects a finished srdf file.

Edit: Currently this is also only working without an error since we load the description from the parameter inside the moveit launchfile which we want to get rid of anyway.

Edit2: My assumption was wrong. We can indeed pass an srdf with parametrization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants