Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish joint temperature #446

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tassos
Copy link

@tassos tassos commented Aug 3, 2021

Since we need temperature information on the motor level for parameters identification, I implemented publishers for publishing the joint temperature as retrieved by the driver. I am making a pull request in case this would be useful for others too, and to get some feedback on my implementation.

Based on previous discussions at #35 and ros-industrial/ur_modern_driver#81, I used the sensor_msgs::Temperature message type and constructed a publisher for each joint. I have two questions:

@fmauch
Copy link
Collaborator

fmauch commented Aug 3, 2021

Please see #35

I'd like to get this fixed all together.

@tassos
Copy link
Author

tassos commented Aug 3, 2021

I can understand that this PR is way more general, but is it actually still work in progress, cause it seems a bit stalled.

@fmauch
Copy link
Collaborator

fmauch commented Aug 5, 2021

That's right. That also means, that any help in this would be very appreciated :-)

@tassos
Copy link
Author

tassos commented Aug 5, 2021

Ok got it. I will see if I can somehow contribute there then. Feel free to close this pull request then, and in case someone needs urgently temperature measurements, they can check out the corresponding branch.

@fmauch
Copy link
Collaborator

fmauch commented Aug 5, 2021

Ok got it. I will see if I can somehow contribute there then. Feel free to close this pull request then, and in case someone needs urgently temperature measurements, they can check out the corresponding branch.

That's why I would leave it open. It would be awesome if you could contribute to #35 I would very much like to get this done, but couldn't find the time to tackle it, yet.

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

This PR hasn't made any progress for quite some time and will be closed soon. Please comment if it is still relevant.

@github-actions github-actions bot added the Stale label Apr 2, 2023
@fmauch
Copy link
Collaborator

fmauch commented Apr 11, 2023

please keep.

@github-actions github-actions bot removed the Stale label Apr 11, 2023
@github-actions
Copy link

This PR hasn't made any progress for quite some time and will be closed soon. Please comment if it is still relevant.

@github-actions github-actions bot added the Stale label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants