Save a show's tracklist to Spotify #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markspolakovs
requested review from
Brookke,
mstratford and
ColinRoitt
and removed request for
Brookke
markspolakovs
commented
May 18, 2020
| }) | ||
| } | ||
|
|
||
| async function savePlaylistToSpotify(thisEl, tracklistContainerEl, showName) { |
There was a problem hiding this comment.
Using async functions => doesn't support IE11
markspolakovs
commented
May 18, 2020
| const state = (Math.random() * 1e6).toString(10); | ||
| const authWindow = window.open( | ||
| "https://accounts.spotify.com/authorize?" + | ||
| "client_id=59c103779bf341fb80f8ac527ea05808" + |
There was a problem hiding this comment.
This needs to become a config variable
|
Just testing this... At least on localhost I get a 404 to /_redirect after authing Spotify, is that expected? |
|
@mstratford That's expected, the JS should catch the redirect and close the popup. If it doesn't, now that's a bug. |
markspolakovs
commented
Jun 23, 2020
| "https://accounts.spotify.com/authorize?" + | ||
| "client_id=59c103779bf341fb80f8ac527ea05808" + | ||
| "&response_type=token" + | ||
| "&redirect_uri=" + encodeURIComponent("http://localhost:3000/_redirect") + |
There was a problem hiding this comment.
Er, that shouldn't be localhost
|
I guess I should look at this lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.