Website now serves meeting icals #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request, @RandoomJD! @michael-grace, would you mind reviewing this PR, please? Feel free to ask anyone for help if you're not quite sure what you're doing. |
michael-grace
requested changes
Sep 30, 2020
| func (m *EventsModel) Get() ([]myradio.Event, error) { | ||
| today := time.Now().Truncate(time.Hour * 24) | ||
| start := today.Format("20060102T150405Z") | ||
| end := today.AddDate(1, 0, 0).Format("20060102T150405Z") |
There was a problem hiding this comment.
these lines would be better off in myradio-go when creating the request, to allow a time.Time to be passed in
| @@ -66,7 +66,7 @@ | |||
| <br> | |||
| <h1 class="text-center">Come see us!</h1> | |||
| <br> | |||
| <p class="text-center">We have a calendar of <a href="https://goo.gl/5APK7Q">all our meetings</a>, to which new members are always welcome, and you can drop by the station almost any time and there'll be someone to talk to.</p> | |||
| <p class="text-center">We have a calendar of <a href="/meetings.ics">all our meetings</a>, to which new members are always welcome, and you can drop by the station almost any time and there'll be someone to talk to.</p> | |||
There was a problem hiding this comment.
will this give people an easy to read format, or just an integration?? also, this page only shows up once in someone's ury lifetime, so it maybe isn't best on the main website and keep it to myradio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires myradio-go: james-events pull request