Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update podcasts page and podcast microsites to match the 2016-23 style #369

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

GravyJonesGalleon
Copy link
Contributor

Podcast Microsite

  • Moved the player to match shows/timeslot microsite
  • Improved and restyled the copy player iframe option
  • Improved linking
  • Prettified page
    N.B. There is a problem with the myradio API, it is not returning the associated show

Podcasts page

  • Improved linking
  • Fixed next/previous/latest
  • Applied rounding & other styling

@Keeeeeeeen
Copy link
Contributor

Hey Owen, looks great, just a little suggestion on the Microsite front, could we maybe move the "Listen to more podcasts on demand..." link? (Blue hyperlink text on a blue background isn't particularly easy to see) Maybe we could move it to the bottom near or just above the embed link, and then have the player centred? Other than that it I'm really happy with it :)

@GravyJonesGalleon
Copy link
Contributor Author

GravyJonesGalleon commented Jul 3, 2024

could we maybe move the "Listen to more podcasts on demand..." link? (Blue hyperlink text on a blue background isn't particularly easy to see) Maybe we could move it to the bottom near or just above the embed link, and then have the player centred?

As far as I can see, the link is on the white card, underneath the player and everything is centred. I am assuming this is something I have done wrong with the css and screen sizing. I'll look into it shortly

@GravyJonesGalleon
Copy link
Contributor Author

Hey @Keeeeeeeen, I think the changes I've just made should sort the problem. The player ought to be centered and the links should be nice and visible on the card. Please let me know if it is working properly now!

Copy link
Contributor

@Keeeeeeeen Keeeeeeeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Keeeeeeeen Keeeeeeeen merged commit a83a9c6 into development Jul 13, 2024
2 checks passed
@GravyJonesGalleon GravyJonesGalleon deleted the owen-podcasts branch July 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants