Remove duplicate credits from credit string. #1004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not yet tested.
|
Looks like a universal improvement to me, but I don't know much PHP these days 😅 |
|
|
||
| return empty($str) ? '' : substr($str, 0, -2); | ||
| return empty($names) ? '' : $str; |
There was a problem hiding this comment.
Is there any reason why this can't be empty($names) ? '' : implode(", ",$names)? Alternatively, what happens when implode is called on an empty array - if it's just '', could this ternary be eliminated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet tested.