podcast categories #1060
Open
podcast categories #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markspolakovs
requested changes
Jun 19, 2022
Comment on lines
+13
to
+15
| alter table uryplayer.podcast_category | ||
| add constraint podcast_category_pk | ||
| primary key (podcast_category_id); |
There was a problem hiding this comment.
This could be done in the create table (podcast_category_id SERIAL NOT NULL PRIMARY KEY
Comment on lines
+10
to
+11
| create unique index podcast_category_podcast_category_id_uindex | ||
| on uryplayer.podcast_category (podcast_category_id); |
There was a problem hiding this comment.
Nitpick: redundant if it's already a primary key
| insert into uryplayer.podcast_category (category_name) values ('URY Podcast'), ('Music Team Interview'); | ||
|
|
||
| alter table uryplayer.podcast | ||
| add category_id int; |
There was a problem hiding this comment.
Could this be add category_id int references uryplayer.podcast_category (podcast_category_id)? Saves an extra ALTER.
| @@ -485,7 +512,8 @@ public static function create( | |||
| $tags, | |||
| $file, | |||
| MyRadio_Show $show = null, | |||
| $credits = null | |||
| $credits = null, | |||
| $category_id | |||
There was a problem hiding this comment.
This might need to be before the optional parameters ($show and friends)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
won't lie - not tested
closes: #1057