Jp jukebox activesong #1128
Open
Jp jukebox activesong #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -687,6 +688,8 @@ public static function getCurrentAndNext($time = null, $n = 1, $filter = [1]) | |||
| $timeslot = self::getCurrentTimeslot($time, $filter); | |||
| $next = self::getNextTimeslot($time, $filter); | |||
|
|
|||
| $currentJukebox = iTones_playlist::getPlaylistAtTime(date('H:i:s')); | |||
There was a problem hiding this comment.
Suggested change
| $currentJukebox = iTones_playlist::getPlaylistAtTime(date('H:i:s')); | |
| $currentJukebox = iTones_Playlist::getPlaylistAtTime(date('H:i:s')); |
| 'SELECT playlist.playlistid | ||
| FROM jukebox.playlists playlist | ||
| INNER JOIN jukebox.playlist_availability avail ON playlist.playlistid=avail.playlistid | ||
| WHERE playlist.category=2 |
There was a problem hiding this comment.
Do we have a Config variable for the category ID? We'd rather not hard-code it if possible.
| @@ -235,6 +235,27 @@ public function getTitle() | |||
| return $this->title; | |||
| } | |||
|
|
|||
| public function getPlaylistAtTime($time) | |||
There was a problem hiding this comment.
What will this do if there are multiple active playlists at a time?
There was a problem hiding this comment.
just return one of them. This shouldn't matter as we are planning to move to only having a single active playlist at any point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current jukebox playlist display on timelord