CS restore training map #874
Conversation
Removes old image variable and adds in "text"
Allows you to get names of all people with a certain training
Removes the old empty image and shows the query result
|
Actually I need to consider if the SQL query takes the right test value. This might show the names of people but not necessarily those with that training, depending on if I got it right. My test sample was 2 users with self-gained training so this could have caused that issue. All I would need to do is change the "WHERE" condition to the right value |
There was a problem hiding this comment.
This seems fair. Might be worth being called getAllTrained or something.
It may be worth looking at removing the MyRadio Daemon associated with generation of the images. In production it's disabled in the config because it typically breaks after a PHP upgrade. It uses a lot of graphics PHP packages to do it, which are often forgotten.
|
I'm torn between essentially returning all the users as MyRadio_User so you can link to them, but I also know that there's a lot of overhead there for a list of people. So I'm not too fussed. |
There was a problem hiding this comment.
This works, but per @mstratford I'm not entirely sure this is the best way of doing things - what if you, for example, want links to each person's profile?
Overhead in a list of MyRadio_User objects shouldn't be that bad, even if it's everyone studio trainer trained...
Bear in mind this is my first time doing PHP so it can likely be adjusted. This is mostly an initial stage to see how well it works. I've tested this out locally and it seems to display everything fairly okay. Query in the main PHP file gives the expected result in our database too.