Make training depends and can_award arrays #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the Great 2020 Training Reshuffle, we're adding the first training status that has multiple prerequisites. Now, I'm a lazy bastard who can't be bothered to write the code for that, so instead I'll just make that perm have no prerequisites, and instead give whoever can give it the ability to give anything ;)
So my previous PR wasn't enough... This PR switched training status dependencies to arrays of typeids instead of typeids, and makes the dependency checks use AND-logic - i.e. the depends and can_award columns will now be a list of training statuses you must have.
michael-grace
approved these changes
Jul 15, 2020
Basically, if dependencies is empty, it should mean that ANYONE can be given that training, but if can_award is empty it should be NOBODY. The earlier commit had the latter backwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So my previous PR wasn't enough...
This PR switched training status dependencies to arrays of typeids instead of typeids, and makes the dependency checks use AND-logic - i.e. the depends and can_award columns will now be a list of training statuses you must have.
Will test on dev in a sec.