Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profile end-of-life #928

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

markspolakovs
Copy link
Member

@markspolakovs markspolakovs commented Aug 23, 2020

$domain = Config::$email_domain;
$long_name = Config::$long_name;
$short_name = Config::$short_name;
mail(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be an existing send mail function somewhere

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment immediately above:

We use mail() manually to avoid hacking with the innards of MyRadioEmail (as it'd refuse to send due to receive_email being false)

You do have a valid point though, and it may be better to refactor MRE to allow "send immediately, even if they've opted out".

Copy link
Contributor

@cs-endo cs-endo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - can't say I can confirm the php entirely (so I won't approve) but I don't see any obvious issues throughout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants