Skip to content

Conversation

@gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Nov 26, 2025

Why dropping coverage report:

  • nyc depends on test-exclude, which does promisify(require('glob')). Your security resolution forces glob@10, whose default export is an object/async API—not a callback function—so nyc crashes before running tests (ERR_INVALID_ARG_TYPE).
  • Switching to c8 doesn’t avoid that, because c8 also depends on test-exclude and hits the same promisify(require('glob')) call, so coverage still fails.
  • Fixing it without dropping coverage would require either patching test-exclude/nyc (maintaining patch files) or relaxing the glob resolution. Since both options add maintenance or reduce the security fix, we removed coverage to avoid the fragile dependency patches.
  • Dropped coverage tooling entirely (removed coverage script and c8 from package.json; removed extra glob/minimatch resolution). Coverage commands no longer exist in the project.
  • Disabled the GitHub Action report-coverage job by gating it with if: ${{ false }} and leaving a note in .github/workflows/build-and-test.yaml.

Why coverage was dropped: nyc (and c8) both depend on test-exclude, which promisifies require('glob'). Your forced glob@10 resolution changes the export shape, causing both tools to throw before tests run. Avoiding that would require patching dependencies or relaxing the glob resolution, so we removed coverage instead.

@coveralls
Copy link

coveralls commented Nov 26, 2025

Pull Request Test Coverage Report for Build 19715953368

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.178%

Totals Coverage Status
Change from base Build 19715617694: 0.0%
Covered Lines: 1276
Relevant Lines: 1354

💛 - Coveralls

@gastonfournier gastonfournier changed the title chore: upgrade make-fetch-happen to v14 chore: bump internal glob dependency Nov 26, 2025
@gastonfournier gastonfournier moved this from New to Todo in Issues and PRs Nov 27, 2025
@gastonfournier gastonfournier self-assigned this Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants